Re: [PATCH] Staging: omap4iss: fix coding style issues

[Ozgur Karatas]

28.01.2017, 20:11, "Avraham Shukron" <avraham.shukron@xxxxxxxxx>:
> This is a patch that fixes issues in omap4iss/iss_video.c
> Specifically, it fixes "line over 80 characters" issues

Hello,

are you have a sent this changes patch before?
And Greg KH answered you, are you read?

Please send the change once, there is no need for a repeat. 

> Signed-off-by: Avraham Shukron <avraham.shukron@xxxxxxxxx>
>
> ---
> Âdrivers/staging/media/omap4iss/iss_video.c | 7 ++++---
> Â1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index c16927a..cdab053 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -298,7 +298,8 @@ iss_video_check_format(struct iss_video *video, struct iss_video_fh *vfh)
>
> Âstatic int iss_video_queue_setup(struct vb2_queue *vq,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂunsigned int *count, unsigned int *num_planes,
> - unsigned int sizes[], struct device *alloc_devs[])
> + unsigned int sizes[],
> + struct device *alloc_devs[])

it should be on the same line, maintainer's up to 80 characters allowed.
this "alloc_devs" variable start with int?

Example:

struct device {
  int (struct device *alloc_devs[);

Check the top lines of the codes.


> Â{
> ÂÂÂÂÂÂÂÂÂstruct iss_video_fh *vfh = vb2_get_drv_priv(vq);
> ÂÂÂÂÂÂÂÂÂstruct iss_video *video = vfh->video;
> @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh, struct v4l2_selection *sel)
> ÂÂÂÂÂÂÂÂÂif (subdev == NULL)
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn -EINVAL;
>
> - /* Try the get selection operation first and fallback to get format if not
> - * implemented.
> + /* Try the get selection operation first and fallback to get format if
> + * not implemented.
> ÂÂÂÂÂÂÂÂÂÂ*/

There is no change here, it opens with comment /* and closes with */.
Please read submittting patch document.

Regards,

> ÂÂÂÂÂÂÂÂÂsdsel.pad = pad;
> ÂÂÂÂÂÂÂÂÂret = v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel);
> --
> 2.7.4

~Ozgur