Re: [PATCH v4 3/3] p54: convert to sysdata API

[Linus Torvalds]

On Thu, Jan 26, 2017 at 1:50 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
>
> OK I've added a respective helper call which would map 1-1 with the
> old sync mechanism to enable a 1-1 change, this will be called
> driver_data_request_simple(), but let me know if there is a preference
> for something else.

So just looking at this patch, what's the *advantage* to the driver writer?

Apart from the actual new feature, this patch seems to actively make
the driver uglier.

I mentioned this before, but replacing "request_firmware()" with
"driver_data_request_simple()" is SIMPLY NOT AN IMPROVEMENT.

The new name is longer and _less_ descriptive.

So I'm really not seeing why you want to make these conversions that
just make code worse.

                Linus