Re: [PATCH v4] net: ethernet: faraday: To support device tree usage.

From: David Miller
Date: Wed Jan 25 2017 - 12:34:56 EST


From: Greentime Hu <green.hu@xxxxxxxxx>
Date: Tue, 24 Jan 2017 16:46:14 +0800

> We also use the same binding document to describe the same faraday ethernet
> controller and add faraday to vendor-prefixes.txt.
>
> Signed-off-by: Greentime Hu <green.hu@xxxxxxxxx>
> ---
> Changes in v4:
> - Use the same binding document to describe the same faraday ethernet controller and add faraday to vendor-prefixes.txt.
> Changes in v3:
> - Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt.
> Changes in v2:
> - Change atmac100_of_ids to ftmac100_of_ids
>
> ---
> .../net/{moxa,moxart-mac.txt => faraday,ftmac.txt} | 7 +++++--
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
> 3 files changed, 13 insertions(+), 2 deletions(-)
> rename Documentation/devicetree/bindings/net/{moxa,moxart-mac.txt => faraday,ftmac.txt} (68%)
>
> diff --git a/Documentation/devicetree/bindings/net/moxa,moxart-mac.txt b/Documentation/devicetree/bindings/net/faraday,ftmac.txt
> similarity index 68%
> rename from Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
> rename to Documentation/devicetree/bindings/net/faraday,ftmac.txt

Why are you renaming the MOXA binding file instead of adding a completely new one
for faraday? The MOXA one should stick around, I don't see a justification for
removing it.