Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute

From: Gideon D'souza
Date: Tue Jan 24 2017 - 23:50:58 EST


>#define __mode(x) __attribute__((mode(x)))
Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.

On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> taken up, to replace gcc specific attributes with macros.
>>
>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> crypto: Replaced gcc specific attributes with macros from compiler.h
>>
>> The last commit of this task that went through you: 52f5684c8e1ec
>> kernel: use macros from compiler.h instead of __attribute__((...))
>>
>> The next patch is for cleaning up the m68k subsystem and it requires
>> a new macro to wrap __attribute__ ((mode (...)))
> []
>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> []
>> @@ -121,6 +121,7 @@
>> #define __attribute_const__ __attribute__((__const__))
>> #define __maybe_unused __attribute__((unused))
>> #define __always_unused __attribute__((unused))
>> +#define __mode __attribute__((mode(x)))
>
> Huh?
>
> Perhaps you meant
>
> #define __mode(x) __attribute__((mode(x)))
>
> ?
>