Re: [PATCH] bpf: don't kfree an uninitialized im_node

From: Alexei Starovoitov
Date: Tue Jan 24 2017 - 12:54:12 EST


On Tue, Jan 24, 2017 at 6:16 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> There are some error exit paths to the label 'out' that end up
> kfree'ing an uninitialized im_node. Fix this by inititializing
> im_node to NULL to avoid kfree'ing a garbage address.

this fix already landed. See:
commit d140199af510 ("bpf, lpm: fix kfree of im_node in trie_update_elem")

> Issue found by CoverityScan, CID#1398022 ("Uninitialized pointer read")

Nice. Good to know that static analysis can do such checks.