Re: [PATCH] platform/x86: fujitsu-laptop: rework logolamp_set() to properly handle errors

From: Andy Shevchenko
Date: Fri Jan 06 2017 - 15:48:23 EST


On Fri, Jan 6, 2017 at 9:24 PM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:
>> On Thu, Jan 5, 2017 at 3:11 PM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:

>> > + int ret, poweron = FUNC_LED_OFF, always = FUNC_LED_OFF;
>> > +

Don't know if you are already about to send v2, though I would see two
lines of above instead of one.
int ...;
int ret;


--
With Best Regards,
Andy Shevchenko