Re: [PATCH v3 3/9] arm64: cpufeature: Cleanup feature bit tables

From: Catalin Marinas
Date: Thu Jan 05 2017 - 12:19:27 EST


On Wed, Jan 04, 2017 at 05:49:01PM +0000, Suzuki K. Poulose wrote:
> This patch does the following clean ups :
>
> 1) All undescribed fields of a register are now treated as "strict"
> with a safe value of 0. Hence we could leave an empty table for
> describing registers which are RAZ.
>
> 2) ID_AA64DFR1_EL1 is RAZ and should use the table for RAZ register.
>
> 3) ftr_generic32 is used to represent a register with a 32bit feature
> value. Rename this to ftr_singl32 to make it more obvious. Since
> we don't have a 64bit singe feature register, kill ftr_generic.

Nitpick: couple of "single" typos above.

>
> Based on a patch by Mark Rutland.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>

Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>