Re: [PATCH] hv: use substraction to update ring buffer index

From: Dan Carpenter
Date: Thu Jan 05 2017 - 06:51:08 EST


On Thu, Jan 05, 2017 at 02:39:55PM +0300, Dan Carpenter wrote:
> > @@ -179,7 +180,8 @@ static u32 hv_copyfrom_ringbuffer(
> > memcpy(dest, ring_buffer + start_read_offset, destlen);
> >
> > start_read_offset += destlen;
> > - start_read_offset %= ring_buffer_size;
> > + if (start_read_offset >= ring_buffer_size)
> > + start_read_offset -= ring_buffer_size;
>
> I totally don't understand the original code here. We do the memset

I meant memcpy() not memset.

regards,
dan carpenter