RE: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings

From: Troy Jia
Date: Wed Jan 04 2017 - 21:29:00 EST




> -----Original Message-----
> From: Scott Wood [mailto:oss@xxxxxxxxxxxx]
> Sent: Wednesday, January 04, 2017 6:38 PM
> To: Troy Jia <hongtao.jia@xxxxxxx>; rui.zhang@xxxxxxxxx; edubezval@xxxxxxxxx;
> Y.T. Tang <yuantian.tang@xxxxxxx>; robh+dt@xxxxxxxxxx
> Cc: linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
>
> On Wed, 2017-01-04 at 16:57 +0800, Jia Hongtao wrote:
> > For different types of SoC the sensor id and endianness may vary.
> > "#thermal-sensor-cells" is used to provide sensor id information.
> > "little-endian" property is to tell the endianness of TMU.
> >
> > Signed-off-by: Jia Hongtao <hongtao.jia@xxxxxxx>
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > ÂDocumentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7
> > +++++++
> > Â1 file changed, 7 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > index 66223d5..20ca4ef 100644
> > --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > @@ -17,6 +17,12 @@ Required properties:
> > Â calibration data, as specified by the SoC reference manual.
> > Â The first cell of each pair is the value to be written to TTCFGR,
> > Â and the second is the value to be written to TSCFGR.
> > +- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
> > + site ID, and represents the "n" in TRITSRn and TRATSRn.
>
> I assume the driver will continue to work with existing device trees where this
> information is absent? ÂIf so, ACK for the whole series.

Yes. The driver works for all existing device trees.

Thanks for the ACK.

>
> -Scott