[PATCH v2] dell-wmi, dell-laptop: hide dell-smbios

From: Jean Delvare
Date: Wed Jan 04 2017 - 08:00:23 EST


Dell-smbios is a helper module, it serves no purpose on its own, so
do not present it as an option to the user. Instead, select it
automatically whenever a driver which needs it is selected.

Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Cc: MichaÅ KÄpieÅ <kernel@xxxxxxxxxx>
Cc: Pali RohÃr <pali.rohar@xxxxxxxxx>
Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more
user-friendly and avoids the confusing transitive dependencies
which Pali didn't like.

drivers/platform/x86/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-4.10-rc2.orig/drivers/platform/x86/Kconfig 2017-01-01 23:31:53.000000000 +0100
+++ linux-4.10-rc2/drivers/platform/x86/Kconfig 2017-01-04 13:53:41.691262664 +0100
@@ -92,8 +92,8 @@ config ASUS_LAPTOP
If you have an ACPI-compatible ASUS laptop, say Y or M here.

config DELL_SMBIOS
- tristate "Dell SMBIOS Support"
- depends on DCDBAS
+ tristate
+ select DCDBAS
default n
---help---
This module provides common functions for kernel modules using
@@ -103,12 +103,12 @@ config DELL_SMBIOS

config DELL_LAPTOP
tristate "Dell Laptop Extras"
- depends on DELL_SMBIOS
depends on DMI
depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on RFKILL || RFKILL = n
depends on SERIO_I8042
+ select DELL_SMBIOS
select POWER_SUPPLY
select LEDS_CLASS
select NEW_LEDS
@@ -123,7 +123,7 @@ config DELL_WMI
depends on DMI
depends on INPUT
depends on ACPI_VIDEO || ACPI_VIDEO = n
- depends on DELL_SMBIOS
+ select DELL_SMBIOS
select INPUT_SPARSEKMAP
---help---
Say Y here if you want to support WMI-based hotkeys on Dell laptops.

--
Jean Delvare
SUSE L3 Support