Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

[Felipe Balbi]

Hi,

Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote:
>> Hi,
>> 
>> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
>> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
>> > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
>> > > to be loaded to get the PHY going and ohci-omap should wait for those.
>> > > 
>> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
>> > 
>> > Is this a new bug?  The 770 has been around for forever, why has this
>> > not been a problem before now?
>> 
>> PHY/OTG support for 770 has been around only since v3.14.
>
> 3.14 was released March, 2014.  A long time ago in kernel development :)
>
>> I was previously compiling phy-tahvo as built-in, and bumped into this
>> issue when compiling it as a module.
>
> Why not just make the defconfig as built-in?
>
> I'm not objecting to this patch, just really curious why no one else has
> ever hit it.

Aaro is likely to be the last active OMAP1 user (let alone hacker)
around. This is probably just a reflection of that fact. No-one else was
using N770 with upstream (at least with USB in mind) :-)

-- 
balbi