Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

[Andy Shevchenko]

On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote:
> Fall back to usual allocation method if DMA coherent allocation fails.
> 
> SPI framework will map and use DMA mapped memory when possible.

Locally I have re-done DMA approach and thus this patch became optional.

Should I leave or remove it? Opinions?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Âdrivers/staging/fbtft/fbtft-core.c | 3 ++-
> Â1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-core.c
> b/drivers/staging/fbtft/fbtft-core.c
> index 226be8c09768..9f024986aff4 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -843,7 +843,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct
> fbtft_display *display,
> Â		if (dma) {
> Â			txbuf = dmam_alloc_coherent(dev, txbuflen,
> Â						ÂÂÂÂ&par->txbuf.dma,
> GFP_DMA);
> -		} else
> +		}
> +		if (!txbuf)
> Â#endif
> Â		{
> Â			txbuf = devm_kzalloc(par->info->device,

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy