Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand

From: Boris Brezillon
Date: Tue Jan 03 2017 - 08:14:35 EST


Hi Sekhar,

On Tue, 3 Jan 2017 17:07:44 +0530
Sekhar Nori <nsekhar@xxxxxx> wrote:

> Hi Boris,
>
> On Tuesday 03 January 2017 02:29 PM, Boris Brezillon wrote:
> > Hi Sushaanth,
>
> Sushaanth is not with TI anymore. You might have received a bounce.

Indeed.

>
> >
> > Sorry for the late reply, I'm dequeing old NAND related patches and
> > found this one.
> >
> > Is this patch still needed?
>
> I dont think so. I suspect the real root cause was addressed by Karl in
> commit f6d7c1b5598b ("mtd: nand: davinci: Reinitialize the HW ECC
> engine in 4bit hwctl")

Okay, cool. I'll just mark the patch as 'Superseeded' in patchwork.

>
> I just ran mtd_subpagetest on my da850 lcdk board and it passed[1]. If
> there are more tests to run to determine if subpage write really works,
> let me know too.

No, that should be good.

>
> I suspect even the original workaround for keystone boards may not be
> needed after Karl's patch. I will test and send a patch dropping the
> workaround altogether if the tests succeed.

Sounds good.

Thanks,

Boris