Re: [PATCH v2 1/4] pinctrl: samsung: Fix the width of PINCFG_TYPE_DRV bitfields for Exynos5433

From: Andi Shyti
Date: Tue Jan 03 2017 - 04:46:06 EST


Hi Linus and Krzysztof,

> > > From: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > >
> > > This patch fixes the wrong width of PINCFG_TYPE_DRV bitfields for Exynos5433
> > > because PINCFG_TYPE_DRV of Exynos5433 has 4bit fields in the *_DRV
> > > registers. Usually, other Exynos have 2bit field for PINCFG_TYPE_DRV.
> > >
> > > Fixes: 3c5ecc9ed353 ("pinctrl: exynos: Add support for Exynos5433")
> > > Cc: stable@xxxxxxxxxxxxxxx
> > > Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> > > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > > Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > > Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> > > Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> >
> > Nominally I think you should sign this off too Andi, as you are in the delivery
> > path.
> >
> > Patch applied for fixes.
>
> That has to be signed by Andi... otherwise the chain is broken (and
> there could be changes added inside).

yes, sorry about this. If Linus wants and it's not too late, he
can add my signed off at the bottom.

Thanks,
Andi