Re: [3/5] pinctrl: core: Add generic pinctrl functions for managing groups

From: Gary Bisson
Date: Mon Jan 02 2017 - 11:21:21 EST


Hi Tony,

On Tue, Dec 27, 2016 at 09:20:01AM -0800, Tony Lindgren wrote:
> We can add generic helpers for function handling for cases where the pin
> controller driver does not need to use static arrays.
>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

Shouldn't the patch title be:
pinctrl: core: Add generic pinmux functions for managing functions

It looks like a copy/paste issue since both patches have the same title:
824bef17d16c pinctrl: core: Add generic pinctrl functions for managing
groups
d70a0fb14682 pinctrl: core: Add generic pinctrl functions for managing
groups

That's actually my only remark, I had another comment about freeing the
trees but it is actually done in the unregister so everything is good.

Regards,
Gary