Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration

From: Javier Martinez Canillas
Date: Mon Jan 02 2017 - 11:13:38 EST


Hello Arnd,

On 01/02/2017 01:05 PM, Arnd Bergmann wrote:
> On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module if the device isn't registered via OF.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> I think we can just remove the table, as the platform only supports
> booting through DT anyway.
>

Agreed. I should had checked if mach-picoxcell was DT-only indeed.

Should I also make the driver to depend on OF and remove the #ifdefery then?

> Arnd
>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America