Re: [PATCH] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int

From: David Miller
Date: Fri Dec 30 2016 - 15:23:42 EST


From: Pavel Tikhomirov <ptikhomirov@xxxxxxxxxxxxx>
Date: Thu, 29 Dec 2016 17:35:07 +0300

> @@ -958,7 +959,9 @@ static struct ctl_table ipv4_net_table[] = {
> .data = &init_net.ipv4.sysctl_tcp_notsent_lowat,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_doulongvec_minmax,
> + .extra1 = &zero,
> + .extra2 = &uint_max,

It seems much simpler to use "proc_douintvec()" to fix this bug.

Doesn't it?