Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred device for ppmu device

From: MyungJoo Ham
Date: Fri Dec 30 2016 - 05:35:22 EST


On Wed, Dec 28, 2016 at 8:56 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> This patch just adds the simple log to show the PPMU device's registration
> during the kernel booting.
>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
> drivers/devfreq/event/exynos-ppmu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index fb3706faf5bd..9b5294d0bff4 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -591,7 +591,7 @@ static int exynos_ppmu_parse_dt(struct platform_device *pdev,
> info->ppmu.clk = devm_clk_get(dev, "ppmu");
> if (IS_ERR(info->ppmu.clk)) {
> info->ppmu.clk = NULL;
> - dev_warn(dev, "cannot get PPMU clock\n");
> + dev_dbg(dev, "cannot get PPMU clock\n");

Do you really want not to emit warning with a clock not found?

> }
>
> ret = of_get_devfreq_events(np, info);
> @@ -643,6 +643,9 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
> "failed to add devfreq-event device\n");
> return PTR_ERR(edev[i]);
> }
> +
> + pr_info("exynos-ppmu: new PPMU device registered %s (%s)\n",
> + dev_name(&pdev->dev), desc[i].name);
> }
>
> clk_prepare_enable(info->ppmu.clk);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics