Re: [PATCH 6/6] ubifs: Wire up NFS support

From: Richard Weinberger
Date: Thu Dec 29 2016 - 03:48:41 EST


Bruce,

On 29.12.2016 03:56, J. Bruce Fields wrote:
>> - * Note, d_splice_alias() would be required instead if we supported
>> - * NFS.
>> - */
>> - d_add(dentry, inode);
>> +
>> + d_splice_alias(inode, dentry);
>> return NULL;
>
> I'm pretty sure that should be
>
> return d_splice_alias(inode, dentry);

You are right.
/me assumed d_splice_alias() is consistent with d_add(). :-(

Thanks,
//richard