Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

[Nicolas Saenz Julienne]

Hi Manish, thanks for the interest.

On 20/12/16 17:54, Manish Badarkhe wrote:
> Hi Nicola
>
[...]
>
> Just some general comment, Can you add some more properties here to
> know voltage and current?

I assume you are mentioning reading current and voltage values. These
properties are not supported by the sbs-charger standard. All you can do
is set (write only) the charging current and charging voltage values.
Yet in all the boards I've worked with it's the sbs-battery compliant
chip that takes care of it.

> Also, can you add other properties present in charging status register
> like POWER_FAIL, VOLTAGE_OR,
> CURRENT_OR etc.

CURRENT_OR and VOLTAGE_OR relate to wrong values in the charging
voltage/current registers. Since the sbs-battery chip takes care of it I
don't see any use for it.
POWER_FAIL marks there is not enough voltage to charge the battery. I
don't need that information so I did nothing to integrate it. Having a
quick look at the power supply defines I don't see were it could easily fit.

> Don't know weather it is feasible to add or not and Also, let me know,
> if it is already been covered in
> some part of the code.
> 
> Thanks
> Manish Badarkhe
> 

Regards,
Nicolas