RE: [PATCH] acpi: Fix format string type mistakes

[Moore, Robert]

> -----Original Message-----
> From: keescook@xxxxxxxxxx [mailto:keescook@xxxxxxxxxx] On Behalf Of Kees
> Cook
> Sent: Friday, December 16, 2016 3:04 PM
> To: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Cc: Moore, Robert <robert.moore@xxxxxxxxx>; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>; Zheng, Lv <lv.zheng@xxxxxxxxx>; Wysocki,
> Rafael J <rafael.j.wysocki@xxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; ACPI
> Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx>; Emese Revfy
> <re.emese@xxxxxxxxx>; devel@xxxxxxxxxx
> Subject: Re: [PATCH] acpi: Fix format string type mistakes
> 
> On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx>
> wrote:
> > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keescook@xxxxxxxxxxxx>
> wrote:
> >> From: Emese Revfy <re.emese@xxxxxxxxx>
> >>
> >> This adds the missing __printf attribute which allows compile time
> >> format string checking (and will be used by the coming initify gcc
> >> plugin). Additionally, this fixes the warnings exposed by the
> attribute.
> >>
> >> Signed-off-by: Emese Revfy <re.emese@xxxxxxxxx>
> >> [kees: split scsi/acpi, merged attr and fix, new commit messages]
> >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >
> > This modifies code that we get from an external projiect (ACPICA) and
> > the bugs should be fixed in there in the first place.
> 
> Who should get CCed?
> 
> > Moreover, I'm not sure if adding __printf in acpiosxf.h is a good
> idea.
> 
> Why not? This is going to be needed by the initify plugin to do correct
> detection of what's being passed around to functions...
> 

[Moore, Robert] It's compiler-dependent.

> -Kees
> 
> --
> Kees Cook
> Nexus Security