Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

From: James Simmons
Date: Mon Dec 19 2016 - 11:39:06 EST



> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
>
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
>
> This patch fixes this issue.

Acked-by: James Simmons <jsimmons@xxxxxxxxxxxxx>

> Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
> Signed-off-by: Quentin Lambert <lambert.quentin@xxxxxxxxx>
> ---
> v2: fixes the referenced sha
>
> drivers/staging/lustre/lustre/include/obd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/lustre/lustre/include/obd.h
> +++ b/drivers/staging/lustre/lustre/include/obd.h
> @@ -889,7 +889,7 @@ struct obd_client_handle {
> struct md_open_data *och_mod;
> struct lustre_handle och_lease_handle; /* open lock for lease */
> __u32 och_magic;
> - int och_flags;
> + fmode_t och_flags;
> };
>
> #define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
>