Re: [PATCH 2/2] rtc: jz4740: make the driver builtin only

[Geert Uytterhoeven]

Hi Alexandre,

On Wed, Nov 9, 2016 at 1:37 AM, Alexandre Belloni
<alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:
> Since the driver is now calling machine_halt() that is not exported, it has
> to be built in the kernel. Building it as a module will fail at linking
> time.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/rtc/Kconfig      |  5 +----
>  drivers/rtc/rtc-jz4740.c | 10 +---------
>  2 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 4259ce61c31b..24b0778f6e28 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1550,15 +1550,12 @@ config RTC_DRV_MPC5121
>           will be called rtc-mpc5121.
>
>  config RTC_DRV_JZ4740
> -       tristate "Ingenic JZ4740 SoC"
> +       bool "Ingenic JZ4740 SoC"

Just noticed RTC_DRV_JZ4740 flipped from m to y.

This is bad for distribution kernels.
Can't the driver just call kernel_halt() instead of machine_halt()?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds