Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

From: Scott Matheina
Date: Sun Dec 18 2016 - 14:40:22 EST


I just read an email from Linus saying keep the line length shorter than 100, so my patch isn't necessary. I sent the v2 out today, but wasn't aware of 100 being the new limit checkpatch.pl still has 80 as the limit. Sorry to bother. Please disregard my patch.

On 12/18/2016 11:43 AM, Scott Matheina wrote:


On 12/18/2016 01:46 AM, Greg KH wrote:
On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
Signed-off-by: Scott Matheina <scott@xxxxxxxxxxxx>
I can't take patches without any changelog text :(
Yah. Forgot to add the description. Added for v2.
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
index a6e3af7..4e371ed 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)

va_end(args);
fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
- par->info->device, u8, buf, len, "%s: ", __func__);
- }
+ par->info->device, u8, buf, len,
+ "%s: ", __func__);
+}
I don't think you did this correctly, do you?
I looked at this, and made a change to the line break, but if you're talking about
the code itself then I'll have to dig into the books to figure that out. Starting small
and learn from reading the code and making some small changes while I figure
it out.