Re: [PATCH 1/3] staging: android: remove ION_IOC_SYNC

From: Matthew Smith
Date: Fri Dec 16 2016 - 18:27:22 EST


On Fri, Dec 16, 2016 at 03:05:54PM -0800, Laura Abbott wrote:
> The 'remove' from that TODO is more than just removing the code.
> There's also an implicit 'replace it with something else'. The
> work to do this is still ongoing (see some of my latest patches).
> NAK for all 3 of these patches right now.

Ah that makes a bit more sense.

> The patches themselves looked structurally good. For your commit
> message next time, explain why the code was being changed, not
> just what was changed.

Thank you for the advice, I'll remember that for next time :)