Re: Moratorium on coding style patches (was Re: [PATCH] include/linux/kernel.h: fixed coding style issues)

From: Greg KH
Date: Thu Dec 15 2016 - 12:13:31 EST


On Thu, Dec 15, 2016 at 11:54:54AM +0000, Måns Rullgård wrote:
> Joe Perches <joe@xxxxxxxxxxx> writes:
>
> > On Wed, 2016-12-14 at 18:13 +0000, Måns Rullgård wrote:
> >> Alexey Dobriyan <adobriyan@xxxxxxxxx> writes:
> >> > I call for a tree wide moratorium on pure coding style changes.
> > []
> >> I'd relax this slightly and say don't do style
> >> patches unless as a prelude to some real work.
> >
> > And exclude drivers/staging
>
> I wouldn't mind seeing staging deleted. What makes those drivers so
> special that they deserve to be included in the main tree without
> meeting even the most basic of standards normally required?

Because it provides both a place where people can learn in a "safe"
place, and it allows companies to get their code into the tree so that
others can use it, and it allows users to use their hardware when there
is no other driver availble and no one has done the work to get it
cleaned up yet "properly".

If you don't like staging, fine, ignore it, but don't ask to have it be
deleted if you don't even understand why it was created, why it is used,
and who it is for.

Basic education and manners people, please.

greg k-h