Re: [PATCH] printk: Remove no longer used second struct cont

From: Petr Mladek
Date: Thu Dec 15 2016 - 11:23:48 EST


On Thu 2016-12-15 13:53:58, Geert Uytterhoeven wrote:
> If CONFIG_PRINTK=n:
>
> kernel/printk/printk.c:1893: warning: âcontâ defined but not used
>
> Note that there are actually two different struct cont definitions and
> objects: the first one is used if CONFIG_PRINTK=y, the second one became
> unused by removing console_cont_flush().
>
> Fixes: 5c2992ee7fd8a29d ("printk: remove console flushing special cases for partial buffered lines")

Great catch. It seems that nobody tried the build without CONFIG_PRINTK
at that time.


> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr