Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

[Chris Chiu]

On Wed, Dec 14, 2016 at 6:20 PM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> On Mon, 12 Dec 2016, Chris Chiu wrote:
>
> [ ... snip ... ]
>> +static const struct hid_device_id asus_rog_devices[] = {
>> +     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY1) },
>> +     { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY2) },
>> +     { }
>> +};
>> +MODULE_DEVICE_TABLE(hid, asus_rog_devices);
>
> [ ... snip ... ]
>
> In addition to what Benjamin said already, you also seem to be missing
> hid_have_special_driver[] entry for these VID/PIDs
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

You're right. I forgot to add VID/PID in hid_have_special_driver in
this patch. I'll modify per Benjamin's suggestion and re-commit.
Thanks.