Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

[Geert Uytterhoeven]

Hi Mark,

On Wed, Dec 14, 2016 at 3:37 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:
>> If NO_DMA=y:
>
>>     ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
>
>> Add a dependency on HAS_DMA to fix this.
>
> Honestly I think we should just fix the architectures that don't support
> DMA to provide compile out stubs for DMA, it seems like these
> dependencies are more trouble than they're worth.

Will that really help?

Then people will start adding "depends on HAS_DMA || COMPILE_TEST"
instead...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds