Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

From: Josh Triplett
Date: Wed Dec 14 2016 - 04:51:23 EST


On Wed, Dec 14, 2016 at 10:11:19AM +0100, Arnd Bergmann wrote:
> On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> > >
> > > --- a/drivers/char/Kconfig
> > > +++ b/drivers/char/Kconfig
> > > @@ -589,10 +589,13 @@ config TELCLOCK
> > > controlling the behavior of this hardware.
> > >
> > > config DEVPORT
> > > - bool
> > > + bool "/dev/port character device"
> >
> > bool "/dev/port character device" if EXPERT?
>
> I think the 'default y' is good enough, there are good reasons
> even for non-EXPERT configurations to turn this off.

Agreed. /dev/port seems like something the majority of modern systems
can safely turn off.