Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

From: Kalle Valo
Date: Tue Dec 13 2016 - 06:35:55 EST


Andy Lutomirski <luto@xxxxxxxxxx> writes:

> Eric Biggers pointed out that the orinoco driver pointed scatterlists
> at the stack.
>
> Fix it by switching from ahash to shash. The result should be
> simpler, faster, and more correct.
>
> Cc: stable@xxxxxxxxxxxxxxx # 4.9 only
> Reported-by: Eric Biggers <ebiggers3@xxxxxxxxx>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>

"more correct"? Does this fix a real user visible bug or what? And why
just stable 4.9, does this maybe have something to do with
CONFIG_VMAP_STACK?

I'm just wondering should I push this to 4.10 or -next. This is a driver
for ancient hardware so I'm starting to lean for -next.

--
Kalle Valo