Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

From: Ben Evans
Date: Mon Dec 12 2016 - 09:52:11 EST


This was done to conform to the Lustre Coding Guidelines.

-Ben

On 12/10/16, 1:14 PM, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>
wrote:

>On Sat, Dec 10, 2016 at 01:05:59PM -0500, James Simmons wrote:
>> From: Ben Evans <bevans@xxxxxxxx>
>>
>> It was found if you sort the headers alphabetically
>> that it reduced patch conflicts. This patch sorts
>> the headers alphabetically and also place linux
>> header first, then uapi header and finally the
>> lustre kernel headers.
>
>I still don't agree, when did you last have a patch conflict with this
>file in the .h section? And exactly how hard was it to fix it up?
>
>I'm all for cleanups, but really, this is useless. And I said so the
>last time you sent it...
>
>greg k-h