Re: [PATCH 7/7] hwrng: core: Remove two unused include

[kbuild test robot]

Hi Corentin,

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on v4.9-rc8 next-20161209]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Corentin-Labbe/hwrng-core-do-not-use-multiple-blank-lines/20161210-072632
config: i386-randconfig-i0-201649 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/char/hw_random/core.c: In function 'rng_dev_open':
>> drivers/char/hw_random/core.c:169:11: error: dereferencing pointer to incomplete type
     if ((filp->f_mode & FMODE_READ) == 0)
              ^
   drivers/char/hw_random/core.c:169:22: error: 'FMODE_READ' undeclared (first use in this function)
     if ((filp->f_mode & FMODE_READ) == 0)
                         ^
   drivers/char/hw_random/core.c:169:22: note: each undeclared identifier is reported only once for each function it appears in
   drivers/char/hw_random/core.c:171:10: error: dereferencing pointer to incomplete type
     if (filp->f_mode & FMODE_WRITE)
             ^
   drivers/char/hw_random/core.c:171:21: error: 'FMODE_WRITE' undeclared (first use in this function)
     if (filp->f_mode & FMODE_WRITE)
                        ^
   drivers/char/hw_random/core.c: In function 'rng_dev_read':
   drivers/char/hw_random/core.c:221:11: error: dereferencing pointer to incomplete type
        !(filp->f_flags & O_NONBLOCK));
              ^
   drivers/char/hw_random/core.c:221:23: error: 'O_NONBLOCK' undeclared (first use in this function)
        !(filp->f_flags & O_NONBLOCK));
                          ^
   drivers/char/hw_random/core.c:230:12: error: dereferencing pointer to incomplete type
       if (filp->f_flags & O_NONBLOCK) {
               ^
   drivers/char/hw_random/core.c: At top level:
   drivers/char/hw_random/core.c:272:21: error: variable 'rng_chrdev_ops' has initializer but incomplete type
    static const struct file_operations rng_chrdev_ops = {
                        ^
   drivers/char/hw_random/core.c:273:2: error: unknown field 'owner' specified in initializer
     .owner  = THIS_MODULE,
     ^
   In file included from include/linux/linkage.h:6:0,
                    from include/linux/kernel.h:6,
                    from include/linux/delay.h:10,
                    from drivers/char/hw_random/core.c:13:
   include/linux/export.h:37:30: warning: excess elements in struct initializer [enabled by default]
    #define THIS_MODULE ((struct module *)0)
                                 ^
   drivers/char/hw_random/core.c:273:12: note: in expansion of macro 'THIS_MODULE'
     .owner  = THIS_MODULE,
               ^
   include/linux/export.h:37:30: warning: (near initialization for 'rng_chrdev_ops') [enabled by default]
    #define THIS_MODULE ((struct module *)0)
                                 ^
   drivers/char/hw_random/core.c:273:12: note: in expansion of macro 'THIS_MODULE'
     .owner  = THIS_MODULE,
               ^
   drivers/char/hw_random/core.c:274:2: error: unknown field 'open' specified in initializer
     .open  = rng_dev_open,
     ^
   drivers/char/hw_random/core.c:274:2: warning: excess elements in struct initializer [enabled by default]
   drivers/char/hw_random/core.c:274:2: warning: (near initialization for 'rng_chrdev_ops') [enabled by default]
   drivers/char/hw_random/core.c:275:2: error: unknown field 'read' specified in initializer
     .read  = rng_dev_read,
     ^
   drivers/char/hw_random/core.c:275:2: warning: excess elements in struct initializer [enabled by default]
   drivers/char/hw_random/core.c:275:2: warning: (near initialization for 'rng_chrdev_ops') [enabled by default]
   drivers/char/hw_random/core.c:276:2: error: unknown field 'llseek' specified in initializer
     .llseek  = noop_llseek,
     ^
   drivers/char/hw_random/core.c:276:13: error: 'noop_llseek' undeclared here (not in a function)
     .llseek  = noop_llseek,
                ^
   drivers/char/hw_random/core.c:276:2: warning: excess elements in struct initializer [enabled by default]
     .llseek  = noop_llseek,
     ^
   drivers/char/hw_random/core.c:276:2: warning: (near initialization for 'rng_chrdev_ops') [enabled by default]

vim +169 drivers/char/hw_random/core.c

844dd05f Michael Buesch 2006-06-26  163  	return 0;
844dd05f Michael Buesch 2006-06-26  164  }
844dd05f Michael Buesch 2006-06-26  165  
844dd05f Michael Buesch 2006-06-26  166  static int rng_dev_open(struct inode *inode, struct file *filp)
844dd05f Michael Buesch 2006-06-26  167  {
844dd05f Michael Buesch 2006-06-26  168  	/* enforce read-only access to this chrdev */
844dd05f Michael Buesch 2006-06-26 @169  	if ((filp->f_mode & FMODE_READ) == 0)
844dd05f Michael Buesch 2006-06-26  170  		return -EINVAL;
844dd05f Michael Buesch 2006-06-26  171  	if (filp->f_mode & FMODE_WRITE)
844dd05f Michael Buesch 2006-06-26  172  		return -EINVAL;

:::::: The code at line 169 was first introduced by commit
:::::: 844dd05fec172d98b0dacecd9b9e9f6595204c13 [PATCH] Add new generic HW RNG core

:::::: TO: Michael Buesch <mb@xxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip