Re: [PATCH 06/22] m68k/coldfire: Modernize printing of kernel messages

[Greg Ungerer]

Hi Finn, Geert,

On 08/12/16 08:53, Finn Thain wrote:
> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
>
> >   - Introduce helpers for printing debug messages, incl. dummies for
> >     validating format strings when debugging is disabled,
> >   - Convert from printk() to pr_*(),
> >   - Correct printf()-style format specifiers,
> >   - Drop superfluous casts,
> >
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
> >  arch/m68k/coldfire/m528x.c          |  4 +-
> >  arch/m68k/coldfire/sltimers.c       |  4 +-
> >  arch/m68k/coldfire/timers.c         |  4 +-
> >  arch/m68k/coldfire/vectors.c        |  2 +-
> >  arch/m68k/include/asm/dma.h         | 98 +++++++++++++------------------------
> >  arch/m68k/include/asm/mcf_pgtable.h |  9 ++--
> >  6 files changed, 44 insertions(+), 77 deletions(-)
[snip]
> > diff --git a/arch/m68k/coldfire/vectors.c b/arch/m68k/coldfire/vectors.c
> > index 08923fe600e013d9..a185df5963d4ae50 100644
> > --- a/arch/m68k/coldfire/vectors.c
> > +++ b/arch/m68k/coldfire/vectors.c
> > @@ -24,7 +24,7 @@
> >  asmlinkage void dbginterrupt_c(struct frame *fp)
> >  {
> >  	extern void dump(struct pt_regs *fp);
> > -	printk(KERN_DEBUG "%s(%d): BUS ERROR TRAP\n", __FILE__, __LINE__);
> > +	pr_debug("%s(%d): BUS ERROR TRAP\n", __FILE__, __LINE__);
> >  	dump((struct pt_regs *) fp);
> >  	asm("halt");
> >  }
>
> This file also seems to lack #define DEBUG, so you and Greg might want to
> check this change.

I think we still want this message in, even if DEBUG is
not defined. This code is conditionally compiled in for
hardware debuger processing - and this message should really
come out if this trap case occurs so the user has some idea
that it just tripped. (The text of the message is not perfect,
but that is a separate issue).

Perhaps pr_alert() or pr_crit() would be better?

Regards
Greg