Re: [PATCH] memremap: Remove unused align_* variables

From: Dan Williams
Date: Thu Dec 08 2016 - 12:10:38 EST


On Wed, Dec 7, 2016 at 11:42 PM, Kirtika Ruchandani
<kirtika@xxxxxxxxxxxx> wrote:
> Commit eb7d78c9e7f6 introduced align_start, align_size and align_end
> variables in pgmap_radix_release() but did not use them.
> Compiling with W=1 gives the following harmless warning, fix it to
> reduce the noise with W=1 in the kernel.
>
> kernel/memremap.c: In function âpgmap_radix_releaseâ:
> kernel/memremap.c:199:48: warning: variable âalign_endâ set but not used [-Wunused-but-set-variable]
>
> The call to resource_size has no side-effects and is safe to remove.
>
> Fixes: eb7d78c9e7f6 ("devm_memremap_pages: fix vmem_altmap lifetime + alignment handling")
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Kirtika Ruchandani <kirtika@xxxxxxxxxxxx>

Thanks for the fix, however I'm already addressing this as a side effect of:

https://lkml.org/lkml/2016/12/1/726

I'm in the process of posting v2 of that patch.