Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

From: Boris Ostrovsky
Date: Thu Dec 08 2016 - 09:57:00 EST




On 12/02/2016 01:15 AM, Juergen Gross wrote:
Instead of requesting a new slot on the ring to the backend early, do
so only after all has been setup for the request to be sent. This
makes error handling easier as we don't need to undo the request id
allocation and ring slot allocation.

Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

(although it would be good to have someone familiar with this code look at this as well).