Re: [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

From: Zhouyi Zhou
Date: Wed Dec 07 2016 - 20:21:08 EST


Thanks Jeff for your advice,
Sorry for the my innocence as a Linux kernel rookie.

Zhouyi

On Thu, Dec 8, 2016 at 1:30 AM, Jeff Kirsher
<jeffrey.t.kirsher@xxxxxxxxx> wrote:
> On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote:
>> Signed-off-by: Zhouyi Zhou <yizhouzhou@xxxxxxxxx>
>> Reviewed-by: Cong Wang <xiyou.wangcong@xxxxxxxxx>
>> Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
>> Reviewed-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +++++-
>> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--
>> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> Did Cong, Yuval and Eric give their Reviewed-by offline? I see they made
> comments and suggests, but never saw them actually give you their Reviewed-
> by. You cannot automatically add their Reviewed-by, Signed-off-by, etc
> just because someone provides feedback on your patch.