Re: [PATCH 1/1] cpufreq: Fix NULL pointer comparison warning

From: Viresh Kumar
Date: Tue Dec 06 2016 - 05:29:56 EST


On 06-12-16, 15:47, Mohamed Wasif wrote:
> Replace direct comparisons to NULL
> This problem was detected by checkpatch.
>
> Signed-off-by: Mohamed Wasif <m.wasif@xxxxxxxxxxx>
> ---
> drivers/cpufreq/cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 6e6c1fb..ca3542e 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -590,7 +590,7 @@ static int cpufreq_parse_governor(char *str_governor, unsigned int *policy,
>
> t = find_governor(str_governor);
>
> - if (t == NULL) {
> + if (!t) {
> int ret;
>
> mutex_unlock(&cpufreq_governor_mutex);
> @@ -601,7 +601,7 @@ static int cpufreq_parse_governor(char *str_governor, unsigned int *policy,
> t = find_governor(str_governor);
> }
>
> - if (t != NULL) {
> + if (t) {
> *governor = t;
> err = 0;
> }

What exact checkpatch error did you get ?

This patch would still be not worth it, as the style of comparing with
NULL is just fine. But still I am unable to see the checkpatch warning
in my setup.

--
viresh