Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero board

[Maxime Ripard]

On Mon, Dec 05, 2016 at 04:59:44PM +0800, Icenowy Zheng wrote:
> 
> 2016å12æ5æ 16:52ä Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>åéï
> >
> > On Fri, Dec 02, 2016 at 10:22:30PM +0800, Icenowy Zheng wrote: 
> > > 
> > > 
> > > 01.12.2016, 17:36, "Maxime Ripard" <maxime.ripard@xxxxxxxxxxxxxxxxxx>: 
> > > > On Mon, Nov 28, 2016 at 12:29:07AM +0000, Andrà Przywara wrote: 
> > > >> Â> Something more interesting happened. 
> > > >> Â> 
> > > >> Â> Xunlong made a add-on board for Orange Pi Zero, which exposes the 
> > > >> Â> two USB Controllers exported at expansion bus as USB Type-A 
> > > >> Â> connectors. 
> > > >> Â> 
> > > >> Â> Also it exposes a analog A/V jack and a microphone. 
> > > >> Â> 
> > > >> Â> Should I enable {e,o}hci{2.3} in the device tree? 
> > > >> 
> > > >> ÂActually we should do this regardless of this extension board. The USB 
> > > >> Âpins are not multiplexed and are exposed on user accessible pins (just 
> > > >> Ânot soldered, but that's a detail), so I think they qualify for DT 
> > > >> Âenablement. And even if a user can't use them, it doesn't hurt to have 
> > > >> Âthem (since they are not multiplexed). 
> > > > 
> > > > My main concern about this is that we'll leave regulators enabled by 
> > > > default, for a minority of users. And that minority will prevent to do 
> > > > a proper power management when the times come since we'll have to keep 
> > > > that behaviour forever. 
> > > 
> > > I think these users can add a 'fdt set /xxx/xxx status "disabled" ' . 
> >
> > You can't ask that from the majority of users. These users will take 
> > debian or fedora, install it, and expect everything to work 
> > properly. I would make the opposite argument actually. If someone is 
> > knowledgeable enough to solder the USB pins a connector, then (s)he'll 
> > be able to make that u-boot call. 
> 
> Now (s)he do not need soldering.
> 
> (S)he needs only paying $1.99 more to Xunlong to get the expansion
> board, and insert it on the OPi Zero.

Which is going to require an overlay anyway, so we could have the USB
bits in there too.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature