Re: [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation

From: Borislav Petkov
Date: Fri Dec 02 2016 - 13:50:14 EST


On Fri, Dec 02, 2016 at 10:27:29AM -0800, Linus Torvalds wrote:
> That is, of course, assuming that there is no really subtle reason
> why that stupid sync_core() is there.

Right, we can try to do something like invalidate_icache() or so in
there with the JMP so that the BSP refetches modified code and see where
it gets us.

The good thing is, the early patching paths run before SMP is
up but from looking at load_module(), for example, which does
post_relocation()->module_finalize()->apply_alternatives(), this can
happen late.

Now there I'd like to avoid other cores walking into that address being
patched. Or are we "safe" there in the sense that load_module() happens
on one CPU only sequentially? (I haven't looked at that code to see
what's going on there, actually).

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.