Re: [PATCH v3 1/5] tracing: add __print_flags_u64()

From: Steven Rostedt
Date: Thu Dec 01 2016 - 11:53:55 EST


On Thu, 1 Dec 2016 09:37:47 -0700
Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> wrote:

> Add __print_flags_u64() and the helper trace_print_flags_seq_u64() in the
> same spirit as __print_symbolic_u64() and trace_print_symbols_seq_u64().
> These functions allow us to print symbols associated with flags that are 64
> bits wide even on 32 bit machines.
>
> These will be used by the DAX code so that we can print the flags set in a
> pfn_t such as PFN_SG_CHAIN, PFN_SG_LAST, PFN_DEV and PFN_MAP.
>
> Without this new function I was getting errors like the following when
> compiling for i386:
>
> ./include/linux/pfn_t.h:13:22: warning: large integer implicitly truncated
> to unsigned type [-Woverflow]
> #define PFN_SG_CHAIN (1ULL << (BITS_PER_LONG_LONG - 1))
> ^
>
> Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

Reviewed-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve