RE: RE: RE: [Please Apply][PATCH] Input: misc: bma150: Change msleep to usleep_range for small msecs

[Aniroop Mathur]

Dear Mr. Torokhov,

As this patch is now verified, would you please apply it?

Thank you!

--
Best Regards,
Aniroop Mathur
Lead Engineer |ÂSystem 1Â- Sensor R&D
Samsung Research Institute India - Noida
Tel: 0120-6711111ÂÂÂÂExt: 4018
Mob: +91 9971865523
Email: a.mathur@xxxxxxxxxxx

Â
Â
--------- Original Message ---------
Sender : ZHANG Xu (BST/ESA3.1)Â<Xu.Zhang@xxxxxxxxxxxx>
Date   : 2016-12-01 17:14 (GMT+5:30)
Title  : RE: RE: [PATCH] Input: Change msleep to usleep_range for small msecs
Â
DearÂAniroopÂMathur
Â
GotÂyourÂpoint.Â
ThankÂyouÂforÂyourÂexplanation!
Â
BestÂregards
Â
AlbertÂ(Xu)ÂZHANG
BST/ESA3.1ÂÂ
Â
Â
Â
-----OriginalÂMessage-----
From:ÂAniroopÂMathurÂ[mailto:a.mathur@xxxxxxxxxxx]Â;
Sent:ÂThursday,ÂDecemberÂ01,Â2016Â6:34ÂPM
To:ÂZHANGÂXuÂ(BST/ESA3.1)Â<Xu.Zhang@xxxxxxxxxxxx>;ÂDmitryÂTorokhovÂ<dmitry.torokhov@xxxxxxxxx>;Âlinux-input@xxxxxxxxxxxxxxx;Âlinux-kernel@xxxxxxxxxxxxxxx
Cc:ÂAniroopÂMathurÂ<aniroop.mathur@xxxxxxxxx>;ÂSAMUELÂSEQUEIRAÂ<s.samuel@xxxxxxxxxxx>;ÂRahulÂMahaleÂ<r.mahale@xxxxxxxxxxx>
Subject:ÂRE:ÂRE:Â[PATCH]ÂInput:ÂChangeÂmsleepÂtoÂusleep_rangeÂforÂsmallÂmsecs
Â
DearÂMr.ÂAlbertÂZhang,
Â
ThankÂyouÂforÂyourÂconfirmation!
Â
Yes,ÂIÂthinkÂusleep_range(2000,Â2100)ÂisÂbetterÂthanÂusleep_range(2000,Â2000)
becauseÂdeltaÂtimeÂwillÂallowÂtheÂkernelÂtoÂbatchÂtheÂprocessesÂwhoÂneedÂto
wakeÂupÂaroundÂsameÂtimeÂandÂgenerateÂsingleÂinterruptÂtoÂwakeÂupÂallÂofÂthem.
SoÂthisÂwouldÂbeÂbeneficialÂfromÂpowerÂsavingÂpointÂofÂview.
Â
Â
--
BestÂRegards,
AniroopÂMathur
Â
Â
Â
---------ÂOriginalÂMessageÂ---------
SenderÂ:ÂZHANGÂXuÂ(BST/ESA3.1)Â<Xu.Zhang@xxxxxxxxxxxx>
DateÂÂÂ:Â2016-12-01Â11:19Â(GMT+5:30)
TitleÂÂ:ÂRE:Â[PATCH]ÂInput:ÂChangeÂmsleepÂtoÂusleep_rangeÂforÂsmallÂmsecs
Â
HelloÂAniroopÂMathur
Â
ThankÂyouÂforÂyourÂmail.
Â
WeÂhaveÂusedÂtheÂÂusleep_range()ÂfunctionÂinÂourÂnewÂproduct'sÂdriverÂandÂtheÂverificationÂresultÂÂisÂworking.
YourÂpatchÂforÂbma150ÂisÂdefinitelyÂworkingÂforÂsure.Â
Â
JustÂoneÂquestionÂneedÂyourÂanswer.
ToÂreplaceÂtheÂmsleep(2),ÂÂÂisÂÂusleep_range(2000,Â2100)ÂÂbetterÂÂthanÂusleep_range(2000,Â2000)ÂÂ?
Â
BestÂregards
Â
AlbertÂ(Xu)ÂZHANG
BST/ESA3.1ÂÂ
Â
Â
Â
Â
-----OriginalÂMessage-----
From:Âmathur.aniroop@xxxxxxxxxÂ[mailto:mathur.aniroop@xxxxxxxxx]ÂOnÂBehalfÂOfÂAniroopÂMathur
Sent:ÂTuesday,ÂNovemberÂ29,Â2016Â12:36ÂAM
To:ÂZHANGÂXuÂ(BST/ESA3.1)Â<Xu.Zhang@xxxxxxxxxxxx>;ÂDmitryÂTorokhovÂ<dmitry.torokhov@xxxxxxxxx>;Âlinux-input@xxxxxxxxxxxxxxx;Âlinux-kernel@xxxxxxxxxxxxxxx
Cc:ÂAniroopÂMathurÂ<aniroop.mathur@xxxxxxxxx>;Âs.samuel@xxxxxxxxxxx;Âr.mahale@xxxxxxxxxxx;ÂAniroopÂMathurÂ<a.mathur@xxxxxxxxxxx>
Subject:ÂRe:Â[PATCH]ÂInput:ÂChangeÂmsleepÂtoÂusleep_rangeÂforÂsmallÂmsecs
Â
HelloÂMr.ÂAlbertÂZhang,
Â
IÂamÂAniroopÂMathurÂfromÂSamsungÂR&DÂInstitute,ÂIndia.
Â
IÂhaveÂsubmittedÂoneÂpatchÂasÂbelowÂforÂreviewÂtoÂLinuxÂOpenÂSource.
TheÂproblemÂisÂthatÂweÂdoÂnotÂhaveÂtheÂhardwareÂavailableÂwithÂusÂto
testÂitÂandÂweÂwouldÂlikeÂtoÂtestÂitÂbeforeÂactuallyÂapplyingÂit.
AsÂyouÂareÂtheÂauthorÂofÂthisÂdriver,ÂsoÂIÂwouldÂlikeÂtoÂrequest
youÂifÂyouÂcouldÂhelpÂtoÂtestÂthisÂpatchÂorÂprovideÂusÂtheÂcontactÂpoints
ofÂindividualsÂwhoÂcouldÂsupportÂtoÂgetÂthisÂpatchÂtested?
Â
ThankÂyou!
Â
BR,
AniroopÂMathur
Â
Â
OnÂThu,ÂNovÂ24,Â2016ÂatÂ9:33ÂPM,ÂAniroopÂMathurÂ<a.mathur@xxxxxxxxxxx>Âwrote:
>Âmsleep(1~20)ÂmayÂnotÂdoÂwhatÂtheÂcallerÂintends,ÂandÂwillÂoftenÂsleepÂlonger.
>Â(~20ÂmsÂactualÂsleepÂforÂanyÂvalueÂgivenÂinÂtheÂ1~20msÂrange)
>ÂThisÂisÂnotÂtheÂdesiredÂbehaviourÂforÂmanyÂcasesÂlikeÂdeviceÂresumeÂtime,
>ÂdeviceÂsuspendÂtime,ÂdeviceÂenableÂtime,Âetc.
>ÂThus,ÂchangeÂmsleepÂtoÂusleep_rangeÂforÂpreciseÂwakeups.
>
>ÂSigned-off-by:ÂAniroopÂMathurÂ<a.mathur@xxxxxxxxxxx>
>Â---
>ÂÂdrivers/input/misc/bma150.cÂ|Â4Â++--
>ÂÂ1ÂfileÂchanged,Â2Âinsertions(+),Â2Âdeletions(-)
>
>ÂdiffÂ--gitÂa/drivers/input/misc/bma150.cÂb/drivers/input/misc/bma150.c
>ÂindexÂ2124390..1fa8537Â100644
>Â---Âa/drivers/input/misc/bma150.c
>Â+++Âb/drivers/input/misc/bma150.c
>Â@@Â-207,7Â+207,7Â@@ÂstaticÂintÂbma150_set_mode(structÂbma150_dataÂ*bma150,Âu8Âmode)
>ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturnÂerror;
>
>ÂÂÂÂÂÂÂÂÂifÂ(modeÂ==ÂBMA150_MODE_NORMAL)
>Â-ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmsleep(2);
>Â+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂusleep_range(2000,Â2100);
>
>ÂÂÂÂÂÂÂÂÂbma150->modeÂ=Âmode;
>ÂÂÂÂÂÂÂÂÂreturnÂ0;
>Â@@Â-222,7Â+222,7Â@@ÂstaticÂintÂbma150_soft_reset(structÂbma150_dataÂ*bma150)
>ÂÂÂÂÂÂÂÂÂifÂ(error)
>ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturnÂerror;
>
>Â-ÂÂÂÂÂÂÂmsleep(2);
>Â+ÂÂÂÂÂÂÂusleep_range(2000,Â2100);
>ÂÂÂÂÂÂÂÂÂreturnÂ0;
>ÂÂ}
>
>Â--
>Â2.6.2
>
Â
Â