Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error

From: Charles Keepax
Date: Thu Dec 01 2016 - 04:32:18 EST


On Thu, Dec 01, 2016 at 02:25:44PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
> wm831x_clkout_is_prepared() returns "true" when it fails to read
> CLOCK_CONTROL_1. "true" means the device is already prepared. So
> return "true" on the read failure seems improper.
>
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
> ---

Looks good to me:

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles