Re: [PATCH] perf probe: fix kconfig symbol names for kprobes and uprobes

From: Uwe Kleine-König
Date: Wed Nov 30 2016 - 05:18:02 EST


On Fri, Jul 22, 2016 at 11:00:44AM +0200, Uwe Kleine-König wrote:
> These symbols both don't have a trailing 'S'.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

I just found this patch while rebasing my pending patches. It still
applies and is still correct.

Best regards
Uwe

> ---
> tools/perf/util/probe-file.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c
> index 9aed9c332da6..351268ffdd94 100644
> --- a/tools/perf/util/probe-file.c
> +++ b/tools/perf/util/probe-file.c
> @@ -38,9 +38,9 @@ static void print_open_warning(int err, bool uprobe)
> const char *config;
>
> if (uprobe)
> - config = "CONFIG_UPROBE_EVENTS";
> + config = "CONFIG_UPROBE_EVENT";
> else
> - config = "CONFIG_KPROBE_EVENTS";
> + config = "CONFIG_KPROBE_EVENT";
>
> pr_warning("%cprobe_events file does not exist"
> " - please rebuild kernel with %s.\n",
> @@ -59,8 +59,8 @@ static void print_both_open_warning(int kerr, int uerr)
> if (kerr == -ENOTSUP && uerr == -ENOTSUP)
> pr_warning("Tracefs or debugfs is not mounted.\n");
> else if (kerr == -ENOENT && uerr == -ENOENT)
> - pr_warning("Please rebuild kernel with CONFIG_KPROBE_EVENTS "
> - "or/and CONFIG_UPROBE_EVENTS.\n");
> + pr_warning("Please rebuild kernel with CONFIG_KPROBE_EVENT "
> + "or/and CONFIG_UPROBE_EVENT.\n");
> else {
> char sbuf[STRERR_BUFSIZE];
> pr_warning("Failed to open kprobe events: %s.\n",
> --
> 2.8.1

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |