Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg

From: Linus Torvalds
Date: Tue Nov 29 2016 - 12:18:39 EST


On Tue, Nov 29, 2016 at 9:13 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> How does this look like?

No.

I *really* want people to write out that "I am ok with the allocation failing".

It's not an "inconvenience". It's a sign that you are competent and
that you know it will fail, and that you can handle it.

If you don't show that you know that, we warn about it.

And no, "GFP_NOWAIT" does *not* mean "I have a good fallback".

Linus