Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload

From: Javier Martinez Canillas
Date: Tue Nov 29 2016 - 09:53:30 EST


Hello Jessi,

On 10/24/2016 06:10 AM, Lee Jones wrote:
> On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
>
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> alias: of:N*T*Cmailbox-testC*
>> alias: of:N*T*Cmailbox-test
>>
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> ---
>>
>> drivers/mailbox/mailbox-test.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>

Any comments about this patch and 2/2? Lee acked both patches but
I see that were never picked.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America