Re: [PATCH] net: fec: turn on device when extracting statistics

From: David Miller
Date: Sun Nov 27 2016 - 20:29:59 EST


From: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
Date: Fri, 25 Nov 2016 13:02:00 +0300

> + int i, ret;
> +
> + ret = pm_runtime_get_sync(&fep->pdev->dev);
> + if (IS_ERR_VALUE(ret)) {
> + memset(data, 0, sizeof(*data) * ARRAY_SIZE(fec_stats));
> + return;
> + }

This really isn't the way to do this.

When the device is suspended and the clocks are going to be stopped,
you must fetch the statistic values into a software copy and provide
those if the device is suspended when statistics are requested.