Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

From: Thomas Gleixner
Date: Sat Nov 26 2016 - 08:24:06 EST


On Sat, 26 Nov 2016, Pavel Machek wrote:

> On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > +#ifdef CONFIG_X86_64
> > > +static int phi_r3mwait_disabled __read_mostly;
> > > +
> > > +static int __init phir3mwait_disable(char *__unused)
> > > +{
> > > + phi_r3mwait_disabled = 1;
> > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> >
> > Why would that be a warning? The sysadmin added the command line switch, so
> > why does he needs to be warned?
>
> Its telling admin he did not make a typo on the command line. We often do that....

Definitely not at the warning level.