Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

From: Felipe Balbi
Date: Tue Nov 22 2016 - 07:24:20 EST



Hi,

Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
> Since there is no parameter @value replace it with @legacy.
>
> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params")
> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> ---
> drivers/usb/dwc2/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 11fe68a..10407cb 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -320,7 +320,7 @@ static void dwc2_set_core_param(void *param, u8 size, u64 value)
> * @size: The size of the core parameter in bytes, or 0 for bool.
> *
> * This function looks up @property and sets the @param to that value.
> - * If the property doesn't exist it uses the passed-in @value. It will
> + * If the property doesn't exist it uses the passed-in @legacy value. It will

This doesn't fix any bugs. Also, is @legacy a parameter?

--
balbi

Attachment: signature.asc
Description: PGP signature