Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage

From: David Miller
Date: Mon Nov 14 2016 - 16:21:55 EST


From: Baoquan He <bhe@xxxxxxxxxx>
Date: Sun, 13 Nov 2016 13:01:31 +0800

> This is v2 post.
>
> In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
> firmware requesting code was moved from open stage to probe stage.
> The reason is in kdump kernel hardware iommu need device be reset in
> driver probe stage, otherwise those in-flight DMA from 1st kernel
> will continue going and look up into the newly created io-page tables.
> However bnx2 chip resetting involves firmware requesting issue, that
> need be done in open stage.
>
> Michale Chan suggested we can just wait for the old in-flight DMA to
> complete at probe stage, then though without device resetting, we
> don't need to worry the old in-flight DMA could continue looking up
> the newly created io-page tables.
>
> v1->v2:
> Michael suggested to wait for the in-flight DMA to complete at probe
> stage. So give up the old method of trying to reset chip at probe
> stage, take the new way accordingly.

Series applied and queued up for -stable, thanks.